directorylist: Fix file monitoring implementation
authorMatthias Clasen <mclasen@redhat.com>
Wed, 8 Jul 2020 17:41:01 +0000 (13:41 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 8 Jul 2020 19:08:53 +0000 (15:08 -0400)
The while loops were never advancing the iterator.
Oops.

gtk/gtkdirectorylist.c

index b4a0d100146ce4c67068acfc2e6829af438fe50d..feb3ed044c473db012cbddd432948370f1800891 100644 (file)
@@ -570,8 +570,9 @@ got_existing_file_info_cb (GObject      *source,
 
   g_file_info_set_attribute_object (info, "standard::file", G_OBJECT (file));
 
-  iter = g_sequence_get_begin_iter (self->items);
-  while (!g_sequence_iter_is_end (iter))
+  for (iter = g_sequence_get_begin_iter (self->items);
+       !g_sequence_iter_is_end (iter);
+       iter = g_sequence_iter_next (iter))
     {
       GFileInfo *item = g_sequence_get (iter);
       GFile *f = G_FILE (g_file_info_get_attribute_object (item, "standard::file"));
@@ -591,8 +592,9 @@ gtk_directory_list_remove_file (GtkDirectoryList *self,
 {
   GSequenceIter *iter;
 
-  iter = g_sequence_get_begin_iter (self->items);
-  while (!g_sequence_iter_is_end (iter))
+  for (iter = g_sequence_get_begin_iter (self->items);
+       !g_sequence_iter_is_end (iter);
+       iter = g_sequence_iter_next (iter))
     {
       GFileInfo *item = g_sequence_get (iter);
       GFile *f = G_FILE (g_file_info_get_attribute_object (item, "standard::file"));